[Reference] consistent & complete config examples #4160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
force-pushed
the
consistent-reference-code-examples
branch
2 times, most recently
from
55db0cb to
10da0e8
Compare
| Acme\BlogBundle\Entity\Author | ||
| getters: | ||
| stateInvalid: | ||
| - 'False': | ||
| - False: |
There was a problem hiding this comment.
I think this is wrong - check the caution note that's after the code blocks.
There was a problem hiding this comment.
Oh thanks for noticing @weaverryan.
xabbuh
force-pushed
the
consistent-reference-code-examples
branch
from
10da0e8 to
3d1083f
Compare
xabbuh
force-pushed
the
consistent-reference-code-examples
branch
from
3d1083f to
01dc25c
Compare
|
Wow you're fast @xabbuh! You're probably already doing it :) - but just have 2 other spots where we have quotes that need to go back. Thanks! |
|
Looks good now - I'll just wait for the CI build in case :). |
|
@weaverryan Thanks for spotting them. 👍 The build looks good too. |
|
Merged! |
weaverryan
added a commit
that referenced
this pull request
Aug 25, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [Reference] consistent & complete config examples | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Make configuration examples in the reference section consistent throughout the different configuration formats. Also fixing several syntax issues. This follow #4114 and #4129. Commits ------- 01dc25c [Reference] consistent & complete config examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make configuration examples in the reference section consistent throughout the different configuration formats. Also fixing several syntax issues.
This follow #4114 and #4129.